Home My Page Projects Code Snippets Project Openings SML/NJ
Summary Activity Forums Tracker Lists Tasks Docs Surveys News SCM Files

SCM Repository

[smlnj] Revision 1065
ViewVC logotype

Revision 1065

Jump to revision: Previous Next
Author: george
Date: Thu Feb 14 15:05:16 2002 UTC (17 years, 4 months ago)
Log Message:
Fixed the MLRISC bug sent by Markus Wenzel regarding the compilation
of Isabelle on the x86.

From Allen:
 I've found the problem:

     in ra-core.sml, I use the counter "blocked" to keep track of the
     true number of elements in the freeze queue.  When the counter goes
     to zero, I skip examining the queue.  But I've messed up the
     bookkeeping in combine():

         else ();
         case !ucol of
           PSEUDO => (if !cntv > 0 then
                 (if !cntu > 0 then blocked := !blocked - 1 else ();
                  moveu := mergeMoveList(!movev, !moveu)
              else ();

     combine() is called to coalesce two nodes u and v.
     I think I was thinking that if the move counts of u and v are both
     greater than zero then after they are coalesced then one node is
     removed from the freeze queue.  Apparently I was thinking that
     both u and v are of low degree, but that's clearly not necessarily true.

    Here's the patch.  HOL now compiles.

    I don't know how this impact on performance (compile
    time or runtime).  This bug caused the RA (especially on the x86)
    to go thru the potential spill phase when there are still nodes on the
    freeze queue.

Changed paths:

Path Details
Directorysml/trunk/HISTORY modified , text changed
Directorysml/trunk/src/MLRISC/ra/ra-core.sml modified , text changed
Directorysml/trunk/src/MLRISC/ra/ra-graph.sig modified , text changed
Directorysml/trunk/src/MLRISC/ra/ra-graph.sml modified , text changed
Directorysml/trunk/src/MLRISC/ra/raBitmatrix.sml modified , text changed
Directorysml/trunk/src/MLRISC/visualization/graphLayout.sml modified , text changed

ViewVC Help
Powered by ViewVC 1.0.0