Home My Page Projects Code Snippets Project Openings SML/NJ Bugs
Summary Activity Tracker Lists

[#166] Can't install SML/NJ in directories containing spaces

Date:
2016-07-29 08:15
Priority:
3
State:
Closed
Submitted by:
Bug Submitter (webuser)
Assigned to:
John Reppy (jhr)
Machine Architecture:
None
Operating System:
Generic Unix
Component:
Installer
Resolution:
Fixed
Severity:
Major
OS Version:
Ubuntu
SML/NJ Version:
v110.79
Keywords:
install, config, nlffi
URL:
Transcript (of reproduction):
/home/eush77/dir A/smlnj/config/unpack: Fetching documentation from http://smlnj.cs.uchicago.edu/dist/working/110.79/. Please stand by... /home/eush77/dir A/smlnj/config/unpack: Trying A/smlnj.tgz ... /home/eush77/dir A/smlnj/A/smlnj.tgz: No such file or directory /home/eush77/dir A/smlnj/config/unpack: Trying A/smlnj.tar.gz ... /home/eush77/dir A/smlnj/A/smlnj.tar.gz: No such file or directory /home/eush77/dir A/smlnj/config/unpack: Trying A/smlnj.tar.Z ... /home/eush77/dir A/smlnj/A/smlnj.tar.Z: No such file or directory /home/eush77/dir A/smlnj/config/unpack: Trying A/smlnj.tz ... /home/eush77/dir A/smlnj/A/smlnj.tz: No such file or directory /home/eush77/dir A/smlnj/config/unpack: Trying A/smlnj.tar ... /home/eush77/dir A/smlnj/A/smlnj.tar: No such file or directory /home/eush77/dir A/smlnj/config/unpack: Trying A/smlnj.tar.bz2 ... /home/eush77/dir A/smlnj/A/smlnj.tar.bz2: No such file or directory /home/eush77/dir A/smlnj/config/unpack: Trying 110.79-A/smlnj.tgz ... /home/eush77/dir A/smlnj/110.79-A/smlnj.tgz: No such file or directory /home/eush77/dir A/smlnj/config/unpack: Trying 110.79-A/smlnj.tar.gz ... /home/eush77/dir A/smlnj/110.79-A/smlnj.tar.gz: No such file or directory /home/eush77/dir A/smlnj/config/unpack: Trying 110.79-A/smlnj.tar.Z ... /home/eush77/dir A/smlnj/110.79-A/smlnj.tar.Z: No such file or directory /home/eush77/dir A/smlnj/config/unpack: Trying 110.79-A/smlnj.tz ... /home/eush77/dir A/smlnj/110.79-A/smlnj.tz: No such file or directory /home/eush77/dir A/smlnj/config/unpack: Trying 110.79-A/smlnj.tar ... /home/eush77/dir A/smlnj/110.79-A/smlnj.tar: No such file or directory /home/eush77/dir A/smlnj/config/unpack: Trying 110.79-A/smlnj.tar.bz2 ... /home/eush77/dir A/smlnj/110.79-A/smlnj.tar.bz2: No such file or directory /home/eush77/dir A/smlnj/config/unpack: Fetching 110.79-A/smlnj.tar.bz2 was no success. You should try to do it manually now. /home/eush77/dir A/smlnj/config/unpack: Please, fetch documentation archive (A/smlnj.* or 110.79-A/smlnj.*) from http://smlnj.cs.uchicago.edu/dist/working/110.79/ and then re-run this script! FAILURE: unpacking failed ./config/install.sh: !!! Installation of libraries and programs failed.
Source (for reproduction):
Summary:
Can't install SML/NJ in directories containing spaces

Detailed description
Installation fails if the root directory contains spaces.
Fix:
diff -r smlnj-old/config/unpack smlnj/config/unpack
58c58
< for base in $2 $VERSION-$2 ; do
---
> for base in "$2" "$VERSION-$2" ; do
290c290
< unpack "documentation" $ROOT doc doc
---
> unpack "documentation" "$ROOT" doc doc
diff -r smlnj-old/nlffi/gen/build smlnj/nlffi/gen/build
42c42
< $BUILD ml-nlffigen.cm Main.main $HEAP_IMAGE
---
> "$BUILD" ml-nlffigen.cm Main.main "$HEAP_IMAGE"


Submitted via web form by Eugene <eush77@gmail.com>

Comments:

Message  ↓
Date: 2016-08-04 14:42
Sender: John Reppy

Fixed for 110.80 (needs to be tested).

Attached Files:

Changes

Field Old Value Date By
status_idOpen2016-08-04 14:42jhr
close_dateNone2016-08-04 14:42jhr
assigned_tonone2016-08-04 14:42jhr
detailsInstallation fails if the root directory contains spaces. Fix: diff -r smlnj-old/config/unpack smlnj/config/unpack 58c58 < for base in $2 $VERSION-$2 ; do --- > for base in "$2" "$VERSION-$2" ; do 290c290 < unpack "documentation" $ROOT doc doc --- > unpack "documentation" "$ROOT" doc doc diff -r smlnj-old/nlffi/gen/build smlnj/nlffi/gen/build 42c42 < $BUILD ml-nlffigen.cm Main.main $HEAP_IMAGE --- > "$BUILD" ml-nlffigen.cm Main.main "$HEAP_IMAGE" Submitted via web form by Eugene <eush77@gmail.com> 2016-08-04 14:42jhr
ResolutionNone2016-08-04 14:42jhr
Transcript (of reproduction)/home/eush77/dir A/smlnj/config/unpack: Fetching documentation from http://smlnj.cs.uchicago.edu/dist/working/110.79/. Please stand by... /home/eush77/dir A/smlnj/config/unpack: Trying A/smlnj.tgz ... /home/eush77/dir A/smlnj/A/smlnj.tgz: No such file or directory /home/eush77/dir A/smlnj/config/unpack: Trying A/smlnj.tar.gz ... /home/eush77/dir A/smlnj/A/smlnj.tar.gz: No such file or directory /home/eush77/dir A/smlnj/config/unpack: Trying A/smlnj.tar.Z ... /home/eush77/dir A/smlnj/A/smlnj.tar.Z: No such file or directory /home/eush77/dir A/smlnj/config/unpack: Trying A/smlnj.tz ... /home/eush77/dir A/smlnj/A/smlnj.tz: No such file or directory /home/eush77/dir A/smlnj/config/unpack: Trying A/smlnj.tar ... /home/eush77/dir A/smlnj/A/smlnj.tar: No such file or directory /home/eush77/dir A/smlnj/config/unpack: Trying A/smlnj.tar.bz2 ... /home/eush77/dir A/smlnj/A/smlnj.tar.bz2: No such file or directory /home/eush77/dir A/smlnj/config/unpack: Trying 110.79-A/smlnj.tgz ... /home/eush77/dir A/smlnj/110.79-A/smlnj.tgz: No such file or directory /home/eush77/dir A/smlnj/config/unpack: Trying 110.79-A/smlnj.tar.gz ... /home/eush77/dir A/smlnj/110.79-A/smlnj.tar.gz: No such file or directory /home/eush77/dir A/smlnj/config/unpack: Trying 110.79-A/smlnj.tar.Z ... /home/eush77/dir A/smlnj/110.79-A/smlnj.tar.Z: No such file or directory /home/eush77/dir A/smlnj/config/unpack: Trying 110.79-A/smlnj.tz ... /home/eush77/dir A/smlnj/110.79-A/smlnj.tz: No such file or directory /home/eush77/dir A/smlnj/config/unpack: Trying 110.79-A/smlnj.tar ... /home/eush77/dir A/smlnj/110.79-A/smlnj.tar: No such file or directory /home/eush77/dir A/smlnj/config/unpack: Trying 110.79-A/smlnj.tar.bz2 ... /home/eush77/dir A/smlnj/110.79-A/smlnj.tar.bz2: No such file or directory /home/eush77/dir A/smlnj/config/unpack: Fetching 110.79-A/smlnj.tar.bz2 was no success. You should try to do it manually now. /home/eush77/dir A/smlnj/config/unpack: Please, fetch documentation archive (A/smlnj.* or 110.79-A/smlnj.*) from http://smlnj.cs.uchicago.edu/dist/working/110.79/ and then re-run this script! FAILURE: unpacking failed ./config/install.sh: !!! Installation of libraries and programs failed.2016-08-04 14:42jhr