Home My Page Projects Code Snippets Project Openings SML/NJ Bugs
Summary Activity Tracker Lists

[#183] status code returned by sml REPL

Date:
2017-06-08 15:10
Priority:
3
State:
Closed
Submitted by:
Bug Submitter (webuser)
Assigned to:
John Reppy (jhr)
Machine Architecture:
None
Operating System:
Generic Unix
Component:
Compiler
Resolution:
Fixed
Severity:
Minor
OS Version:
SML/NJ Version:
110.81
Keywords:
URL:
Transcript (of reproduction):
https://github.com/league/qcheck/issues/5#issuecomment-307125426
Source (for reproduction):
Summary:
status code returned by sml REPL

Detailed description
The status code returned by the `sml` REPL changed between 110.79 and
110.81. Previously, if I gave a filename on the command line and it
had a compilation error, sml would return a non-zero status code.

Now, in 110.81, it just issues the error and prints another prompt. If
I specify `</dev/null` on the command line then sml exits, but the
status code is zero despite the error.

This is causing a problem in the build scripts for my qcheck library,
which aims to be usable with every implementation of SML. Its build
script tries to check which basis libraries are available, and it
relied on the status code described above.

The bug report to qcheck is at
<https://github.com/league/qcheck/issues/5#issuecomment-307125426>

If this change in behavior is intentional with a meaningful rationale,
then fine -- I can work around it. But if it was inadvertent I thought
I'd notify you and maybe it can be fixed to work the previous way.
Thanks.

Submitted via web form by Christopher League <league@contrapunctus.net>

Comments:

Message  ↓
Date: 2017-09-18 20:18
Sender: John Reppy

Fixed for 110.82

Attached Files:

Changes

Field Old Value Date By
status_idOpen2017-09-18 20:18jhr
close_dateNone2017-09-18 20:18jhr
ResolutionAccepted As Bug2017-09-18 20:18jhr
assigned_tonone2017-08-28 14:32jhr
detailsThe status code returned by the `sml` REPL changed between 110.79 and 110.81. Previously, if I gave a filename on the command line and it had a compilation error, sml would return a non-zero status code. Now, in 110.81, it just issues the error and prints another prompt. If I specify `</dev/null` on the command line then sml exits, but the status code is zero despite the error. This is causing a problem in the build scripts for my qcheck library, which aims to be usable with every implementation of SML. Its build script tries to check which basis libraries are available, and it relied on the status code described above. The bug report to qcheck is at <https://github.com/league/qcheck/issues/5#issuecomment-307125426> If this change in behavior is intentional with a meaningful rationale, then fine -- I can work around it. But if it was inadvertent I thought I'd notify you and maybe it can be fixed to work the previous way. Thanks. Submitted via web form by Christopher League <league@contrapunctus.net> 2017-08-28 14:32jhr
ResolutionNone2017-08-28 14:32jhr